fix(config): fix parameterMacro typo in type-cast mappings#10841
Open
yogeshwaran-c wants to merge 1 commit intoswagger-api:masterfrom
Open
fix(config): fix parameterMacro typo in type-cast mappings#10841yogeshwaran-c wants to merge 1 commit intoswagger-api:masterfrom
yogeshwaran-c wants to merge 1 commit intoswagger-api:masterfrom
Conversation
The type-cast mapping key was misspelled as "paramaterMacro" instead of "parameterMacro", which meant the parameterMacro configuration option was never properly type-cast when provided via query string or other string-based configuration sources.
82f7825 to
5017c92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The type-cast mapping key for
parameterMacrowas misspelled asparamaterMacro(missing the 'e' in "parameter") insrc/core/config/type-cast/mappings.js.This typo meant that the
parameterMacroconfiguration option was never matched by the type-casting system when provided via query string or other string-based configuration sources. The key inmappings.jsdid not match the key used everywhere else in the codebase (parameterMacroindefaults.js,spec/actions.js,swagger-client/index.js, etc.).Motivation and Context
Found while reviewing the type-cast mappings for completeness. Every other reference in the codebase uses
parameterMacro(with an 'e'), confirming this was an inadvertent typo.How Has This Been Tested?
paramaterMacroandparameterMacromappings.jsused the misspelled versiondefaults.js,spec/actions.js,swagger-client/index.js,parameter-row.jsx) consistently useparameterMacroScreenshots (if appropriate):
N/A
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests